Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: conditionally restore ext/ directory #1097

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Jul 10, 2024

Now that we have to have something in the ext directory, we need to either restore the external ext or the default OSS ext depending on which build we are doing.

@jordigh
Copy link
Contributor Author

jordigh commented Jul 10, 2024

Okay, it looks like this fixed the build:

@paulfitz paulfitz self-requested a review July 10, 2024 14:54
@jordigh jordigh force-pushed the jordigh/fix-oss-build branch from ec9adec to ba85684 Compare July 10, 2024 17:07
Now that we *have* to have something in the ext directory, we need to
either restore the external ext or the default OSS ext depending on
which build we are doing.
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jordigh. This does make me want to fix building tests in the presence of ext, it may be pretty trivial - but not now, this is good.

@jordigh jordigh merged commit 78f5bd9 into main Jul 10, 2024
15 checks passed
@jordigh jordigh deleted the jordigh/fix-oss-build branch July 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants